Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the return type of methods such as Slice#copy_to as Nil #13774

Merged

Conversation

erdian718
Copy link
Contributor

Prevent inadvertent access to unsafe pointers.

Closes #13773

@beta-ziliani beta-ziliani added this to the 1.10.0 milestone Sep 7, 2023
@straight-shoota straight-shoota merged commit 045ad15 into crystal-lang:master Sep 12, 2023
53 checks passed
@straight-shoota straight-shoota added the kind:bug A bug in the code. Does not apply to documentation, specs, etc. label Sep 20, 2023
@erdian718 erdian718 deleted the doc/slice-api-return-value branch September 21, 2023 04:41
Blacksmoke16 pushed a commit to Blacksmoke16/crystal that referenced this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The return value type of Slice#copy_to, etc. should be explicit
4 participants